Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r100975556
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -406,6 +435,14 @@ object GeneralizedLinearRegression extends
DefaultParamsReadable[GeneralizedLine
private[regression] val epsilon: Double = 1E-16
+ /** Checks whether weight column is set and nonempty */
+ private[regression] def isSetWeightCol(params:
GeneralizedLinearRegressionBase): Boolean =
+ params.isSet(params.weightCol) && !params.getWeightCol.isEmpty
+
+ /** Checks whether offset column is set and nonempty */
+ private[regression] def isSetOffsetCol(params:
GeneralizedLinearRegressionBase): Boolean =
+ params.isSet(params.offsetCol) && !params.getOffsetCol.isEmpty
--- End diff --
I adopted `params.getOffsetCol.nonEmpty`.
As for `isDefined` VS `isSet`, in my other PR #16344, @yanboliang suggested
`isSet` is more accurate and we should be using `isSet` and may need to change
the existing `isDefined` at some point. For this reason, I'm using `isSet`
(which I believe checks whether the param is explicitly set by the user).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
