Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15009#discussion_r100935040
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -735,7 +751,11 @@ object SparkSubmit extends CommandLineUtils {
         }
     
         try {
    -      mainMethod.invoke(null, childArgs.toArray)
    +      if (isSparkApp) {
    +        mainMethod.invoke(null, childArgs.toArray, childSparkConf, sys.env)
    --- End diff --
    
    If you're passing `sys.env`, do you need the argument at all? The 
`SparkApp` implementation can just use `sys.env` directly if it needs to. The 
argument would only make sense if you were creating a different env variable 
map based on the launcher's configuration.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to