Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15009#discussion_r100938212
  
    --- Diff: 
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
    @@ -73,6 +74,14 @@
       /** Logger name to use when launching a child process. */
       public static final String CHILD_PROCESS_LOGGER_NAME = 
"spark.launcher.childProcLoggerName";
     
    +  public static final String LAUNCHER_INTERNAL_PORT = 
"spark.launcher.internal.port";
    +
    +  public static final String LAUNCHER_INTERNAL_CHILD_PROCESS_SECRET = 
"spark.launcher.internal.secret";
    +
    +  public static final String LAUNCHER_INTERNAL_STOP_IF_SHUTDOWN = 
"spark.launcher.internal.stop.if.shutdown";
    +
    +  public static final String LAUNCHER_INTERNAL_THREAD_ENABLED = 
"spark.launcher.internal.thread.enabled";
    --- End diff --
    
    Not a fan of the name. How about `LAUNCHER_INTERNAL_USE_THREAD`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to