Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r100938862
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -107,6 +121,30 @@ public static void setConfig(String name, String
value) {
launcherConfig.put(name, value);
}
+ /**
+ * Specifies that Spark Application be stopped if current process goes
away.
+ * It tries stop/kill Spark Application if {@link LauncherServer} goes
away.
+ *
+ * @since 2.2.0
+ * @return This launcher.
+ */
+ public SparkLauncher stopIfLauncherShutdown() {
--- End diff --
Same here; `stopOnShutdown` more closely matches the behavior, since the
behavior is not based on the launcher, but the current app shutting down.
Also, does this work at all for child processes? I don't think so. So the
javadocs should at least say that.
Following from my previous comments, I'm not even sure this option is
necessary. When would you not want this when using child threads? The user can
call `disconnect()` if he doesn't want the child app to fate-share with the
launcher. That would simplify the API.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
