Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1592#discussion_r17514641
--- Diff: python/pyspark/context.py ---
@@ -36,6 +37,65 @@
from py4j.java_collections import ListConverter
+__all__ = ["JavaStackTrace", "SparkContext"]
--- End diff --
This file sets `__all__` further down on line 100; we should only set it
once. Actually, do you mind just moving the `extract_concise_traceback` stuff
to its own file? There's actually an open JIRA ticket for this
([SPARK-1087](https://issues.apache.org/jira/browse/SPARK-1087)) and if you're
going to touch the traceback code anyways now seems like a good time to do this
refactoring. You could name the file something like `traceback_utils.py`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
