Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1592#discussion_r17514679
--- Diff: python/pyspark/sql.py ---
@@ -1624,15 +1636,40 @@ def count(self):
return self._jschema_rdd.count()
def collect(self):
- """
- Return a list that contains all of the rows in this RDD.
+ """Return a list that contains all of the rows in this RDD.
- Each object in the list is on Row, the fields can be accessed as
+ Each object in the list is a Row, the fields can be accessed as
attributes.
+
+ Unlike the base RDD implementation of collect, this implementation
+ leverages the query optimizer to perform a collect on the
SchemaRDD,
+ which supports features such as filter pushdown.
+
+ >>> srdd = sqlCtx.inferSchema(rdd)
+ >>> srdd.collect()
+ [Row(field1=1, field2=u'row1'), ..., Row(field1=3, field2=u'row3')]
"""
- rows = RDD.collect(self)
+ from pyspark.context import JavaStackTrace
--- End diff --
Same here; this import should be at the top of the file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
