Github user JoshRosen commented on a diff in the pull request: https://github.com/apache/spark/pull/1592#discussion_r17514658 --- Diff: python/pyspark/rdd.py --- @@ -704,7 +651,8 @@ def collect(self): """ Return a list that contains all of the elements in this RDD. """ - with _JavaStackTrace(self.context) as st: + from pyspark.context import JavaStackTrace --- End diff -- Can you place this import at the top of the file, alongside the other PySpark imports? If you placed it here to avoid a circular import, then this is further evidence that the traceback functions belong in their own file.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org