Github user chenghao-intel commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17525387
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends RuleExecutor[LogicalPlan] {
Batch("Combine Limits", FixedPoint(100),
CombineLimits) ::
Batch("ConstantFolding", FixedPoint(100),
+ SimplifyCasts,
--- End diff --
I just added an new unit test ```SELECT CAST(CAST('123' AS binary) AS
binary) FROM src LIMIT 1```, this test will fail because the `ConstantFolding`
will try to compute the `foldable` expression prior to `SimplifyCasts`.
Sorry, I should add this test case earlier.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
