Github user adrian-wang commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17526186
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends RuleExecutor[LogicalPlan] {
Batch("Combine Limits", FixedPoint(100),
CombineLimits) ::
Batch("ConstantFolding", FixedPoint(100),
+ SimplifyCasts,
--- End diff --
So maybe it is better to add a match case in the function `lazy val cast:
Any => Any`, to eliminate those meaningless casts. And in this way we'll no
longer need `SimplifyCasts` here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
