Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2368#discussion_r17525906
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -32,12 +32,12 @@ object Optimizer extends RuleExecutor[LogicalPlan] {
Batch("Combine Limits", FixedPoint(100),
CombineLimits) ::
Batch("ConstantFolding", FixedPoint(100),
+ SimplifyCasts,
--- End diff --
Okay, I see. I would argue that's a bug in the casting operator, not a
reason to change the ordering here though.
On Sep 14, 2014 8:09 PM, "Cheng Hao" <[email protected]> wrote:
> In
>
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
>
> > @@ -32,12 +32,12 @@ object Optimizer extends RuleExecutor[LogicalPlan] {
> > Batch("Combine Limits", FixedPoint(100),
> > CombineLimits) ::
> > Batch("ConstantFolding", FixedPoint(100),
> > + SimplifyCasts,
>
> I just added an new unit test SELECT CAST(CAST('123' AS binary) AS
> binary) FROM src LIMIT 1, this test will fail because the ConstantFolding
> will try to compute the foldable expression prior to SimplifyCasts.
> Sorry, I should add this test case earlier.
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/2368/files#r17525387>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
