Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/17122#discussion_r104091814
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
---
@@ -206,6 +206,18 @@ trait CodegenSupport extends SparkPlan {
def doConsume(ctx: CodegenContext, input: Seq[ExprCode], row: ExprCode):
String = {
throw new UnsupportedOperationException
}
+
+ /**
+ * for optimization to suppress shouldStop() in a loop of
WholeStageCodegen
+ *
+ * isShouldStopRequired: require to insert shouldStop() into the loop if
true
+ */
+ def isShouldStopRequired: Boolean = {
+ return shouldStopRequired && !(this.parent != null &&
!this.parent.isShouldStopRequired)
--- End diff --
Thank you for your suggestion. However, it caused an assertion failure at
`"SPARK-7150 range api"` in DataFrameRangeSuite.
In the failure case, `isShouldStopRequired` is called in the class
hierarchy by `parent`.
` RangeExec -> FilterExec -> WholeStageCodegenExec`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
