Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16883#discussion_r104093069
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -71,18 +92,17 @@ class StringIndexer @Since("1.4.0") (
def this() = this(Identifiable.randomUID("strIdx"))
/** @group setParam */
- @Since("1.6.0")
- def setHandleInvalid(value: String): this.type = set(handleInvalid,
value)
- setDefault(handleInvalid, "error")
-
- /** @group setParam */
@Since("1.4.0")
def setInputCol(value: String): this.type = set(inputCol, value)
/** @group setParam */
@Since("1.4.0")
def setOutputCol(value: String): this.type = set(outputCol, value)
+ /** @group setParam */
+ @Since("2.2.0")
+ def setHandleInvalid(value: String): this.type = set(handleInvalid,
value)
--- End diff --
can you keep the order of the params same as before? also, why did the
version change, this method existed before, seems it should remain as version
1.6 (?)
also, minor style comment -- keep the setDefault(handleInvalid) below the
set method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
