Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16883#discussion_r104093629
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -163,25 +187,28 @@ class StringIndexerModel (
}
transformSchema(dataset.schema, logging = true)
+ val metadata = NominalAttribute.defaultAttr
+ .withName($(outputCol)).withValues(labels).toMetadata()
+ // If we are skipping invalid records, filter them out.
+ val (filteredDataset, keepInvalid) = getHandleInvalid match {
--- End diff --
minor style comment: instead of keepInvalid, do you think that indexInvalid
might be a better name (?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
