Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16883#discussion_r104093452
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/StringIndexer.scala ---
@@ -163,25 +190,28 @@ class StringIndexerModel (
}
transformSchema(dataset.schema, logging = true)
+ val metadata = NominalAttribute.defaultAttr
+ .withName($(outputCol)).withValues(labels).toMetadata()
--- End diff --
I think he means that "labels" above should also include the invalid
bucket. In previous ML frameworks I've worked on we've just called this
"unknown".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
