Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/17250#discussion_r105806308
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisInputDStream.scala
---
@@ -31,15 +31,17 @@ import
org.apache.spark.streaming.scheduler.ReceivedBlockInfo
private[kinesis] class KinesisInputDStream[T: ClassTag](
_ssc: StreamingContext,
- streamName: String,
- endpointUrl: String,
- regionName: String,
- initialPositionInStream: InitialPositionInStream,
- checkpointAppName: String,
- checkpointInterval: Duration,
- storageLevel: StorageLevel,
- messageHandler: Record => T,
- kinesisCredsProvider: SerializableCredentialsProvider
+ private[kinesis] val streamName: String,
+ private[kinesis] val endpointUrl: String,
+ private[kinesis] val regionName: String,
+ private[kinesis] val initialPositionInStream: InitialPositionInStream,
+ private[kinesis] val checkpointAppName: String,
+ private[kinesis] val checkpointInterval: Duration,
+ private[kinesis] val _storageLevel: StorageLevel,
--- End diff --
Declaring ```val storageLevel``` collides with
[```DStream.storageLevel```](https://github.com/apache/spark/blob/d5b1d5fc80153571c308130833d0c0774de62c92/streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala#L96)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
