Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15009#discussion_r106229186
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
    @@ -735,7 +749,12 @@ object SparkSubmit extends CommandLineUtils {
         }
     
         try {
    -      mainMethod.invoke(null, childArgs.toArray)
    +      if (isSparkApp) {
    +        val envvars = Map[String, String]() ++ sys.env
    +        mainMethod.invoke(null, childArgs.toArray, childSparkConf, 
envvars.toMap)
    --- End diff --
    
    You're just passing `sys.env` as the environment map to the SparkApp. I've 
already mentioned this before, multiple times. If you're not going to modify 
`sys.env`, then just remove the argument.
    
    (And adding an empty map to `sys.env` does not count as modifying it.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to