Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106234319
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -528,13 +579,42 @@ public SparkAppHandle
startApplication(SparkAppHandle.Listener... listeners) thr
pb.environment().put(LauncherProtocol.ENV_LAUNCHER_PORT,
String.valueOf(LauncherServer.getServerInstance().getPort()));
pb.environment().put(LauncherProtocol.ENV_LAUNCHER_SECRET,
handle.getSecret());
+ pb.environment().put(LauncherProtocol.ENV_LAUNCHER_STOP_IF_SHUTDOWN,
String.valueOf(stopOnShutdown));
try {
handle.setChildProc(pb.start(), loggerName);
} catch (IOException ioe) {
handle.kill();
throw ioe;
}
+ return handle;
+ }
+
+ private SparkAppHandle
startApplicationAsThread(SparkAppHandle.Listener... listeners) throws
IOException {
--- End diff --
nit: line > 100 chars
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
