Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15009#discussion_r106234167
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/SparkLauncher.java ---
@@ -488,11 +545,21 @@ public Process launch() throws IOException {
* In all cases, the logger name will start with
"org.apache.spark.launcher.app", to fit more
* easily into the configuration of commonly-used logging systems.
*
+ * If the application is launched as a thread, the log redirection
methods are not supported,
+ * and the parent process's output and log configuration will be used.
+ *
* @since 1.6.0
* @param listeners Listeners to add to the handle before the app is
launched.
* @return A handle for the launched application.
*/
public SparkAppHandle startApplication(SparkAppHandle.Listener...
listeners) throws IOException {
+ if (launchAsThread) {
+ return startApplicationAsThread(listeners);
+ }
+ return startApplicationAsChildProc(listeners);
+ }
+
+ private SparkAppHandle
startApplicationAsChildProc(SparkAppHandle.Listener[] listeners) throws
IOException {
--- End diff --
nit: line > 100 chars
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
