Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2379#discussion_r17752106
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -44,30 +51,27 @@ private[spark] class HistoryServerArguments(conf:
SparkConf, args: Array[String]
}
}
+ // Use common defaults file, if not specified by user
+ propertiesFile =
Option(propertiesFile).getOrElse(Utils.getDefaultConfigFile)
--- End diff --
I think all daemon properties are pretty specific to the daemons and don't
affect the execution of the application, so it seems safe to me. Once we add
this we should probably also deprecate `SPARK_MASTER_OPTS` etc in favor of
doing it through `spark-defaults.conf`. Then maybe we can add a line in
`spark-defaults.conf.template` that gives an example of a Master config being
set here or something.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
