Github user witgo commented on a diff in the pull request: https://github.com/apache/spark/pull/2379#discussion_r17766151 --- Diff: core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala --- @@ -44,30 +50,19 @@ private[spark] class HistoryServerArguments(conf: SparkConf, args: Array[String] } } + // Use common defaults file, if not specified by user + propertiesFile = Option(propertiesFile).getOrElse(Utils.getDefaultConfigFile) + private def printUsageAndExit(exitCode: Int) { System.err.println( """ - |Usage: HistoryServer - | - |Configuration options can be set by setting the corresponding JVM system property. - |History Server options are always available; additional options depend on the provider. - | - |History Server options: - | - | spark.history.ui.port Port where server will listen for connections - | (default 18080) - | spark.history.acls.enable Whether to enable view acls for all applications - | (default false) - | spark.history.provider Name of history provider class (defaults to - | file system-based provider) - | spark.history.retainedApplications Max number of application UIs to keep loaded in memory - | (default 50) - |FsHistoryProvider options: - | - | spark.history.fs.logDirectory Directory where app logs are stored (required) - | spark.history.fs.updateInterval How often to reload log data from storage (in seconds, - | default 10) - |""".stripMargin) --- End diff -- Only here to show the `spark.*` options is confusing.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org