Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/17533#discussion_r111269273
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -472,6 +472,47 @@ class DAGScheduler(
}
/**
+ * Get ancestor splits in ShuffledRDD.
+ */
+ private[spark] def parentSplitsInShuffledRDD(stageId: Int, pId: Int):
Option[Map[Int, Set[Int]]] =
--- End diff --
this is called both parents and ancestors, which is confusing. I think it
would be most accurate to call it the *stage* parent, and note that requires
traversing some distance up the set of RDD ancestors.
Also I commented on this a bit below ... in general this is pretty
confusing. It seems like there are a lot of cases which get ignored and I am
not certain that's always OK.
Couldn't this entire thing be replaced with
```scala
val deps = getShuffleDependencies(rdd)
val partitioner = deps.head.partitioner
// make sure the partitioner is consistent across all our shuffle
dependencies.
assert(deps.forall{_.partioner == partitioner})
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
