Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17533#discussion_r111233891
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -1080,6 +1122,25 @@ class DAGScheduler(
         }
       }
     
    +  // Visible for testing.
    +  private[spark] def getTaskInputSizesFromShuffledRDD(tasks: 
Seq[Task[_]]): Map[Task[_], Long] = {
    --- End diff --
    
    doesn't look like this needs to be exposed at all for tests.  (and if it 
were used in tests, could probably be a little tighter as `private[scheduler]`.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to