Github user yssharma commented on a diff in the pull request:
https://github.com/apache/spark/pull/17467#discussion_r112848363
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDD.scala
---
@@ -135,7 +139,8 @@ class KinesisSequenceRangeIterator(
endpointUrl: String,
regionId: String,
range: SequenceNumberRange,
- retryTimeoutMs: Int) extends NextIterator[Record] with Logging {
+ retryTimeoutMs: Int,
+ sparkConf: SparkConf) extends NextIterator[Record] with Logging {
--- End diff --
@brkyvz - I was thinking not to pass individual configs to the constructor
because that would just cause the list to grow. Using SparkConf or a Map would
enable us to add new configs without any code changes. I was using a Map
earlier for this so that its easy to pass more configs.
What are your thoughts on Map vs Case class ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
