Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/17467#discussion_r112841794
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisBackedBlockRDD.scala
---
@@ -135,7 +139,8 @@ class KinesisSequenceRangeIterator(
endpointUrl: String,
regionId: String,
range: SequenceNumberRange,
- retryTimeoutMs: Int) extends NextIterator[Record] with Logging {
+ retryTimeoutMs: Int,
+ sparkConf: SparkConf) extends NextIterator[Record] with Logging {
--- End diff --
I wouldn't pass in the `SparkConf` all the way in here. See how
`retryTimeoutMs` has been passed in specifically above. You can do two things:
1. Pass each of them one by one
2. Evaluate all the configurations in `KinesisBackedBlockRDD` or one level
higher and use a `case class` such as `KinesisReadConfigurations`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
