Github user brkyvz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17467#discussion_r112841668
  
    --- Diff: docs/streaming-kinesis-integration.md ---
    @@ -216,3 +216,7 @@ de-aggregate records during consumption.
     - If no Kinesis checkpoint info exists when the input DStream starts, it 
will start either from the oldest record available 
(`InitialPositionInStream.TRIM_HORIZON`) or from the latest tip 
(`InitialPositionInStream.LATEST`).  This is configurable.
       - `InitialPositionInStream.LATEST` could lead to missed records if data 
is added to the stream while no input DStreams are running (and no checkpoint 
info is being stored).
       - `InitialPositionInStream.TRIM_HORIZON` may lead to duplicate 
processing of records where the impact is dependent on checkpoint frequency and 
processing idempotency.
    +
    +#### Kinesis retry configurations
    + - `spark.streaming.kinesis.retry.waitTime` : SparkConf for wait time 
between Kinesis retries (in milliseconds). Default is "100ms".
    --- End diff --
    
    `SparkConf for` is redundant. I would try to focus on when should people 
actually tweak these, why are these confs important in the first place 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to