GitHub user davideis opened a pull request:

    https://github.com/apache/spark/pull/18022

    [SPARK-20790] [MLlib] Correctly handle negative values for implicit feedback

    ## What changes were proposed in this pull request?
    
    Revert the handling of negative values in ALS with implicit feedback, so 
that the confidence is the absolute value of the rating and the preference is 0 
for negative ratings. This was the original behavior.
    
    ## How was this patch tested?
    
    This patch was tested with the existing unit tests and an added unit test 
to ensure that negative ratings are not ignored.
    
    @mengxr 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davideis/spark bugfix/negative-rating

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18022.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18022
    
----
commit 767d72e9bd08cc251aa1df0ce56a4fb8deb9e2e6
Author: David Eis <[email protected]>
Date:   2017-05-02T21:46:29Z

    Fix regression introduced by ccafd757eda478913f783f3127be715bf6413740
    Revert the handling of negative values in ALS with implicit feedback and 
test for regression.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to