Github user davideis commented on a diff in the pull request:
https://github.com/apache/spark/pull/18022#discussion_r117264333
--- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala
---
@@ -795,8 +799,8 @@ object ALS extends DefaultParamsReadable[ALS] with
Logging {
require(a.length == k)
copyToDouble(a)
blas.dspr(upper, k, c, da, 1, ata)
- if (b != 0.0) {
- blas.daxpy(k, c * b, da, 1, atb, 1)
+ if (Math.abs(b) > Double.MinPositiveValue) {
--- End diff --
You are right, I should pick a looser threshold. It seems that this check
is only really to prevent extra work, since daxpy will just be adding a zeros
vector if b==0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
