Github user davideis commented on a diff in the pull request:
https://github.com/apache/spark/pull/18022#discussion_r117260197
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/recommendation/ALSSuite.scala ---
@@ -78,7 +79,7 @@ class ALSSuite
val k = 2
val ne0 = new NormalEquation(k)
.add(Array(1.0f, 2.0f), 3.0)
- .add(Array(4.0f, 5.0f), 6.0, 2.0) // weighted
+ .add(Array(4.0f, 5.0f), 12.0, 2.0) // weighted
--- End diff --
Yes this test change was intentional, because I change the semantic meaning
of the arguments to add, before add would multiply the second and third
arguments together internally, so to make this test valid I premultiplied them
together. In the usage of this function in ALS.scala, for non-implicit the
third argument is 1, so there is no change, and implicit is now handled
correctly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
