Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r120217172
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2658,17 +2658,17 @@ class SQLQuerySuite extends QueryTest with
SharedSQLContext {
sql("select LTRIM(BOTH 'S' FROM 'SS abc S')").head
}
assert(ae1.getMessage contains
- "The specified function ltrim doesn't support with option BOTH")
+ "The specified function LTRIM doesn't support with option BOTH")
val ae2 = intercept[ParseException]{
sql("select RTRIM(TRAILING 'S' FROM 'SS abc S')").head
}
assert(ae2.getMessage contains
- "The specified function rtrim doesn't support with option TRAILING")
+ "The specified function RTRIM doesn't support with option TRAILING")
val ae3 = intercept[ParseException]{
- sql("select TRIM(WINDOW 'S' FROM 'SS abc S')").head
+ sql("select TRIM(OVER 'S' AND 'SS abc S')").head
}
assert(ae3.getMessage contains
- "The specified function trim doesn't support with option WINDOW")
+ "Literals of type 'OVER' are currently not supported")
--- End diff --
Yes, it caused by an earlier checking. I will remove this test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
