Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r120243671
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
---
@@ -578,39 +583,29 @@ case class StringTrim(children: Seq[Expression])
val getTrimFunction = if (children.size == 1) {
s"UTF8String ${ev.value} = ${inputs(0)}.trim();"
} else {
- s"UTF8String ${ev.value} =
${inputs(1)}.trim(${inputs(0)});".stripMargin
+ s"UTF8String ${ev.value} = ${inputs(1)}.trim(${inputs(0)});"
--- End diff --
I can add something like this:
`val inputs = evals.map { eval =>
s"${eval.isNull} ? null : ${eval.value}"
}.reverse`
there are couple places I will add the reverse in each trim function, what
do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
