Github user kevinyu98 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12646#discussion_r120220998
--- Diff:
common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java
---
@@ -746,10 +751,6 @@ public void trim() {
@Test
public void trimLeft() {
- assertEquals(fromString(" hello "), fromString(" hello
").trimLeft(fromString("")));
- assertEquals(fromString(""),
fromString("a").trimLeft(fromString("a")));
- assertEquals(fromString("b"),
fromString("b").trimLeft(fromString("a")));
- assertEquals(fromString("b"),
fromString("b").trimLeft(fromString("a")));
--- End diff --
I thought those test cases are too simple. I will put it back and remove
the duplicate one. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
