Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18322#discussion_r122562201
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -278,6 +278,12 @@ private[deploy] class SparkSubmitArguments(args:
Seq[String], env: Map[String, S
if (pyFiles != null && !isPython) {
SparkSubmit.printErrorAndExit("--py-files given but primary resource
is not a Python script")
}
+ if (totalExecutorCores != null && executorCores != null
+ && (totalExecutorCores.toInt % executorCores.toInt) != 0) {
--- End diff --
Minor, but I think the parentheses are in the wrong place. They should go
around the expression, or probably just be removed. You might avoid duplicating
the mod expression for clarity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
