Github user eatoncys commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18322#discussion_r122638913
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
    @@ -278,6 +278,14 @@ private[deploy] class SparkSubmitArguments(args: 
Seq[String], env: Map[String, S
         if (pyFiles != null && !isPython) {
           SparkSubmit.printErrorAndExit("--py-files given but primary resource 
is not a Python script")
         }
    +    if (totalExecutorCores != null && executorCores != null) {
    --- End diff --
    
    Ok, I have moved it to SparkConf, would you like to review it again, thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to