Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/18322#discussion_r122920139
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -543,6 +543,30 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable with Logging with Seria
}
}
+ if (contains("spark.cores.max")) {
+ val totalCores = getInt("spark.cores.max", -1)
--- End diff --
Please use `Option` instead, I think we don't need to check them if they're
not set. Also looks like if we don't set this configuration, will it always
lead to exception as default value is -1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
