Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17865#discussion_r123183863
--- Diff: python/pyspark/sql/functions.py ---
@@ -200,17 +226,20 @@ def _():
@since(1.3)
def approxCountDistinct(col, rsd=None):
"""
- .. note:: Deprecated in 2.1, use approx_count_distinct instead.
+ .. note:: Deprecated in 2.1, use :func:`approx_count_distinct` instead.
"""
return approx_count_distinct(col, rsd)
@since(2.1)
-def approx_count_distinct(col, rsd=None):
- """Returns a new :class:`Column` for approximate distinct count of
``col``.
+def approx_count_distinct(col, rsd=0.05):
--- End diff --
Why do we change this to `0.05`? We then should change the default values
in both places in `HyperLogLogPlusPlus` and here if we happen to change this
in any event. Let's leave it `None`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
