Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17865#discussion_r123960210
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -426,7 +426,7 @@ setMethod("covar_pop", signature(col1 = 
"characterOrColumn", col2 = "characterOr
     
     #' cos
     #'
    -#' Computes the cosine of the given value.
    +#' Computes the cosine of the given value. Units in radians.
    --- End diff --
    
    Yes, if that one is merged first, we should resolve the conflict here. If 
this one gets merged first, that one should resolve the conflict. Describing 
the same information across APIs looks reasonable to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to