Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/17865#discussion_r123186254
--- Diff: python/pyspark/sql/functions.py ---
@@ -312,7 +338,7 @@ def covar_samp(col1, col2):
@since(1.3)
def countDistinct(col, *cols):
- """Returns a new :class:`Column` for distinct count of ``col`` or
``cols``.
+ """Returns a new :class:`Column` for distinct count of `col` or `cols`.
--- End diff --
I guess we did not decide which one of `` `...` `` or ``` ``...`` ``` is
more preferred and right. Let's avoid sweeping them. Adding new one is fine
(and I usually follow majority in this case) but changing the existing one
might be not if we don't know which one is not preferred. We might happen to
change it forward and backward in time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
