Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18652#discussion_r127853936
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -1912,6 +1913,26 @@ class Analyzer(
               nondeterToAttr.get(e).map(_.toAttribute).getOrElse(e)
             }.copy(child = newChild)
     
    +      case j: Join if j.condition.isDefined && 
!j.condition.get.deterministic =>
    +        j match {
    +          // We can push down non-deterministic joining keys.
    --- End diff --
    
    IIUC, we should not have the same concern (e.g., rand(1) > 0 && rand(11) < 
0) on joining keys. The format of joining keys is "x equal to y". We will 
evaluate x and y for two joining tables. May you show an example we can't push 
down the joining keys?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to