Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18652#discussion_r127894313
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1912,6 +1913,26 @@ class Analyzer(
nondeterToAttr.get(e).map(_.toAttribute).getOrElse(e)
}.copy(child = newChild)
+ case j: Join if j.condition.isDefined &&
!j.condition.get.deterministic =>
+ j match {
+ // We can push down non-deterministic joining keys.
--- End diff --
IIUC, for joining keys, it actually satisfies what you said: It's evaluated
in the same order and in the same number as we don't push it down.
I can't think an example it doesn't. So I may ask if you have an example
for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
