Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18652#discussion_r127891910
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1912,6 +1913,26 @@ class Analyzer(
nondeterToAttr.get(e).map(_.toAttribute).getOrElse(e)
}.copy(child = newChild)
+ case j: Join if j.condition.isDefined &&
!j.condition.get.deterministic =>
+ j match {
+ // We can push down non-deterministic joining keys.
--- End diff --
For different joining type, I think the joining keys are used to find
matching/not matching rows. Currently I can't think of the case we can't push
down non-deterministic joining keys. Maybe you can also show an example?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
