Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18468#discussion_r128679302
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/CachedBatchColumnVector.java
---
@@ -0,0 +1,259 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.sql.execution.vectorized;
+
+import java.nio.ByteBuffer;
+
+import org.apache.spark.memory.MemoryMode;
+import org.apache.spark.sql.catalyst.expressions.UnsafeRow;
+import org.apache.spark.sql.catalyst.expressions.codegen.BufferHolder;
+import org.apache.spark.sql.catalyst.expressions.codegen.UnsafeRowWriter;
+import org.apache.spark.sql.execution.columnar.*;
+import org.apache.spark.sql.types.*;
+import org.apache.spark.unsafe.types.UTF8String;
+
+/**
+ * A column backed by data compressed thru ColumnAccessor
+ * this is a wrapper to read compressed data for table cache
+ */
+public final class CachedBatchColumnVector extends ReadOnlyColumnVector {
+
+ // accessor for a column
+ private ColumnAccessor columnAccessor;
+
+ // a row where the compressed data is extracted
+ private UnsafeRow unsafeRow;
+ private BufferHolder bufferHolder;
+ private UnsafeRowWriter rowWriter;
+ private MutableUnsafeRow mutableRow;
+
+ // an accessor uses only column 0
+ private final int ORDINAL = 0;
+
+ // Keep row id that was previously accessed
+ private int previousRowId = -1;
+
+
+ public CachedBatchColumnVector(byte[] buffer, int numRows, DataType
type) {
+ super(numRows, type, MemoryMode.ON_HEAP);
+ initialize(buffer, type);
+ reset();
+ }
+
+ @Override
+ public long valuesNativeAddress() {
+ throw new RuntimeException("Cannot get native address for on heap
column");
+ }
+ @Override
+ public long nullsNativeAddress() {
+ throw new RuntimeException("Cannot get native address for on heap
column");
+ }
+
+ @Override
+ public void close() {
+ }
+
+ // call extractTo() for rowId only once before getting actual data
+ private void prepareAccess(int rowId) {
+ if (previousRowId == rowId) {
+ // do nothing
+ } else if (previousRowId < rowId) {
+ for (; previousRowId < rowId; previousRowId++) {
+ assert (columnAccessor.hasNext());
+ bufferHolder.reset();
+ rowWriter.zeroOutNullBytes();
+ columnAccessor.extractTo(mutableRow, ORDINAL);
+ }
+ } else {
+ throw new UnsupportedOperationException("Row access order must be
equal or ascending." +
+ " Row " + rowId + "is accessed after row "+ previousRowId + " was
accessed.");
+ }
+ }
+
+ //
+ // APIs dealing with nulls
+ //
+
+ @Override
+ public boolean isNullAt(int rowId) {
+ prepareAccess(rowId);
+ return unsafeRow.isNullAt(ORDINAL);
+ }
+
+ //
+ // APIs dealing with Booleans
+ //
+
+ @Override
+ public boolean getBoolean(int rowId) {
+ prepareAccess(rowId);
+ return unsafeRow.getBoolean(ORDINAL);
+ }
+
+ @Override
+ public boolean[] getBooleans(int rowId, int count) {
+ throw new UnsupportedOperationException();
+ }
+
+ //
+
+ //
+ // APIs dealing with Bytes
+ //
+
+ @Override
+ public byte getByte(int rowId) {
+ prepareAccess(rowId);
+ return unsafeRow.getByte(ORDINAL);
+ }
+
+ @Override
+ public byte[] getBytes(int rowId, int count) {
+ throw new UnsupportedOperationException();
+ }
+
+ //
+ // APIs dealing with Shorts
+ //
+
+ @Override
+ public short getShort(int rowId) {
+ prepareAccess(rowId);
+ return unsafeRow.getShort(ORDINAL);
+ }
+
+ @Override
+ public short[] getShorts(int rowId, int count) {
+ throw new UnsupportedOperationException();
+ }
+
+ //
+ // APIs dealing with Ints
+ //
+
+ @Override
+ public int getInt(int rowId) {
+ prepareAccess(rowId);
+ return unsafeRow.getInt(ORDINAL);
+ }
+
+ @Override
+ public int[] getInts(int rowId, int count) {
+ throw new UnsupportedOperationException();
+ }
+
+ public int getDictId(int rowId) {
+ throw new UnsupportedOperationException();
+ }
+
+ //
+ // APIs dealing with Longs
+ //
+
+ @Override
+ public long getLong(int rowId) {
+ prepareAccess(rowId);
+ return unsafeRow.getLong(ORDINAL);
+ }
+
+ @Override
+ public long[] getLongs(int rowId, int count) {
+ throw new UnsupportedOperationException();
+ }
+
+ //
+ // APIs dealing with floats
+ //
+
+ @Override
+ public float getFloat(int rowId) {
+ prepareAccess(rowId);
+ return unsafeRow.getFloat(ORDINAL);
+ }
+
+ @Override
+ public float[] getFloats(int rowId, int count) {
+ throw new UnsupportedOperationException();
+ }
+
+ //
+ // APIs dealing with doubles
+ //
+
+ @Override
+ public double getDouble(int rowId) {
+ prepareAccess(rowId);
+ return unsafeRow.getDouble(ORDINAL);
+ }
+
+ @Override
+ public double[] getDoubles(int rowId, int count) {
+ throw new UnsupportedOperationException();
+ }
+
+ //
+ // APIs dealing with Arrays
+ //
+
+ @Override
+ public int getArrayLength(int rowId) {
+ throw new UnsupportedOperationException();
+ }
+ @Override
+ public int getArrayOffset(int rowId) {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public void loadBytes(ColumnVector.Array array) {
+ throw new UnsupportedOperationException();
+ }
+
+ //
+ // APIs dealing with Byte Arrays
+ //
+
+ public final UTF8String getUTF8String(int rowId) {
+ prepareAccess(rowId);
+ return unsafeRow.getUTF8String(ORDINAL);
+ }
+
+ private void initialize(byte[] buffer, DataType type) {
+ if (columnAccessor == null) {
--- End diff --
Is this check needed?
I guess this is called only from constructor. ditto for `mutableRow` below.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
