Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18468#discussion_r128678034
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -1248,4 +1251,238 @@ class ColumnarBatchSuite extends SparkFunSuite {
s"vectorized reader"))
}
}
+
+ test("CachedBatch boolean Apis") {
+ val dataType = BooleanType
+ val columnBuilder = ColumnBuilderHelper(dataType, 1024, "col", true)
+ val row = new SpecificInternalRow(Array(dataType))
+
+ val nullRow = InternalRow(false)
+ nullRow.setNullAt(0)
+ columnBuilder.appendFrom(nullRow, 0)
+ for (i <- 1 until 16) {
+ row.setBoolean(0, i % 2 == 0)
+ columnBuilder.appendFrom(row, 0)
+ }
+
+ val column = new CachedBatchColumnVector(
+ JavaUtils.bufferToArray(columnBuilder.build), 1024, dataType)
+
+ assert(column.isNullAt(0) == true)
+ for (i <- 1 until 16) {
+ assert(column.isNullAt(i) == false)
+ assert(column.getBoolean(i) == (i % 2 == 0))
+ }
+ column.close
+ }
+
+ test("CachedBatch byte Apis") {
+ val dataType = ByteType
+ val columnBuilder = ColumnBuilderHelper(dataType, 1024, "col", true)
+ val row = new SpecificInternalRow(Array(dataType))
+
+ val nullRow = InternalRow(false)
+ nullRow.setNullAt(0)
+ columnBuilder.appendFrom(nullRow, 0)
+ for (i <- 1 until 16) {
+ row.setByte(0, i.toByte)
+ columnBuilder.appendFrom(row, 0)
+ }
+
+ val column = new CachedBatchColumnVector(
+ JavaUtils.bufferToArray(columnBuilder.build), 1024, dataType)
+
+ assert(column.isNullAt(0) == true)
+ for (i <- 1 until 16) {
+ assert(column.isNullAt(i) == false)
+ assert(column.getByte(i) == i)
+ }
+ column.close
+ }
+
+ test("CachedBatch short Apis") {
+ val dataType = ShortType
+ val columnBuilder = ColumnBuilderHelper(dataType, 1024, "col", true)
+ val row = new SpecificInternalRow(Array(dataType))
+
+ val nullRow = InternalRow(false)
+ nullRow.setNullAt(0)
+ columnBuilder.appendFrom(nullRow, 0)
+ for (i <- 1 until 16) {
+ row.setShort(0, i.toShort)
+ columnBuilder.appendFrom(row, 0)
+ }
+
+ val column = new CachedBatchColumnVector(
+ JavaUtils.bufferToArray(columnBuilder.build), 1024, dataType)
+
+ assert(column.isNullAt(0) == true)
+ for (i <- 1 until 16) {
+ assert(column.isNullAt(i) == false)
+ assert(column.getShort(i) == i)
+ }
+ column.close
+ }
+
+ test("CachedBatch int Apis") {
+ val dataType = IntegerType
+ val columnBuilder = ColumnBuilderHelper(dataType, 1024, "col", true)
+ val row = new SpecificInternalRow(Array(dataType))
+
+ val nullRow = InternalRow(false)
+ nullRow.setNullAt(0)
+ columnBuilder.appendFrom(nullRow, 0)
+ for (i <- 1 until 16) {
+ row.setInt(0, i)
+ columnBuilder.appendFrom(row, 0)
+ }
+
+ val column = new CachedBatchColumnVector(
+ JavaUtils.bufferToArray(columnBuilder.build), 1024, dataType)
+
+ assert(column.isNullAt(0) == true)
+ for (i <- 1 until 16) {
+ assert(column.isNullAt(i) == false)
+ assert(column.getInt(i) == i)
+ }
+ column.close
+ }
+
+ test("CachedBatch long Apis") {
+ val dataType = LongType
+ val columnBuilder = ColumnBuilderHelper(dataType, 1024, "col", true)
+ val row = new SpecificInternalRow(Array(dataType))
+
+ val nullRow = InternalRow(false)
+ nullRow.setNullAt(0)
+ columnBuilder.appendFrom(nullRow, 0)
+ for (i <- 1 until 16) {
+ row.setLong(0, i.toLong)
+ columnBuilder.appendFrom(row, 0)
+ }
+
+ val column = new CachedBatchColumnVector(
+ JavaUtils.bufferToArray(columnBuilder.build), 1024, dataType)
+
+ assert(column.isNullAt(0) == true)
+ for (i <- 1 until 16) {
+ assert(column.isNullAt(i) == false)
+ assert(column.getLong(i) == i.toLong)
+ }
+ column.close
+ }
+
+ test("CachedBatch float Apis") {
+ val dataType = FloatType
+ val columnBuilder = ColumnBuilderHelper(dataType, 1024, "col", true)
+ val row = new SpecificInternalRow(Array(dataType))
+
+ val nullRow = InternalRow(false)
+ nullRow.setNullAt(0)
+ columnBuilder.appendFrom(nullRow, 0)
+ for (i <- 1 until 16) {
+ row.setFloat(0, i.toFloat)
+ columnBuilder.appendFrom(row, 0)
+ }
+
+ val column = new CachedBatchColumnVector(
+ JavaUtils.bufferToArray(columnBuilder.build), 1024, dataType)
+
+ assert(column.isNullAt(0) == true)
+ for (i <- 1 until 16) {
+ assert(column.isNullAt(i) == false)
+ assert(column.getFloat(i) == i.toFloat)
+ }
+ column.close
+ }
+
+ test("CachedBatch double Apis") {
+ val dataType = DoubleType
+ val columnBuilder = ColumnBuilderHelper(dataType, 1024, "col", true)
+ val row = new SpecificInternalRow(Array(dataType))
+
+ val nullRow = InternalRow(false)
+ nullRow.setNullAt(0)
+ columnBuilder.appendFrom(nullRow, 0)
+ for (i <- 1 until 16) {
+ row.setDouble(0, i.toDouble)
+ columnBuilder.appendFrom(row, 0)
+ }
+
+ val column = new CachedBatchColumnVector(
+ JavaUtils.bufferToArray(columnBuilder.build), 1024, dataType)
+
+ assert(column.isNullAt(0) == true)
+ for (i <- 1 until 16) {
+ assert(column.isNullAt(i) == false)
+ assert(column.getDouble(i) == i.toDouble)
+ }
+ column.close
+ }
+
+ test("CachedBatch String type Apis") {
+ val dataType = StringType
+ val columnBuilder = ColumnBuilderHelper(dataType, 1024, "col", true)
+
+ val nullRow = InternalRow("")
+ nullRow.setNullAt(0)
+ columnBuilder.appendFrom(nullRow, 0)
+ for (i <- 1 until 16) {
+ val converter = UnsafeProjection.create(Array[DataType](dataType))
--- End diff --
Do we need this?
How about simply like the following with `SpecificInternalRow`?
```
row.update(0, UTF8String.fromString(...))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
