Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18468#discussion_r128676879
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchSuite.scala
---
@@ -1248,4 +1251,238 @@ class ColumnarBatchSuite extends SparkFunSuite {
s"vectorized reader"))
}
}
+
+ test("CachedBatch boolean Apis") {
+ val dataType = BooleanType
+ val columnBuilder = ColumnBuilderHelper(dataType, 1024, "col", true)
+ val row = new SpecificInternalRow(Array(dataType))
+
+ val nullRow = InternalRow(false)
--- End diff --
Do we need `nullRow`?
I guess we can use `row` for `null`, too. ditto for other types.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
