Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r18263375
--- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
@@ -234,7 +236,12 @@ object SparkEnv extends Logging {
val shuffleMemoryManager = new ShuffleMemoryManager(conf)
- val blockTransferService = new NioBlockTransferService(conf,
securityManager)
+ // TODO(rxin): Config option based on class name, similar to shuffle
mgr and compression codec.
+ val blockTransferService = if
(conf.getBoolean("spark.shuffle.use.netty", false)) {
--- End diff --
It'd be better if we could go ahead and make the config stable, it's always
painful for people to update later. Even if it's just like
```scala
val blockTransferService = conf.getString("spark.shuffle.transferService",
"NIO") match {
case "NETTY" => new NettyBlockTransferService(conf)
case "NIO" => new NioBlockTransferService(conf, securityManager)
case s => throw new UnsupportedOperationException("Unknown transfer
service: " + s)
}
```
Potentially less pain for when we address the TODO at a later date.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
