Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/2330#discussion_r18263553
--- Diff:
core/src/main/scala/org/apache/spark/network/BlockDataManager.scala ---
@@ -20,14 +20,14 @@ package org.apache.spark.network
import org.apache.spark.storage.StorageLevel
+private[spark]
trait BlockDataManager {
/**
- * Interface to get local block data.
- *
- * @return Some(buffer) if the block exists locally, and None if it
doesn't.
+ * Interface to get local block data. Throws an exception if the block
cannot be found or
+ * cannot be read successfully.
*/
- def getBlockData(blockId: String): Option[ManagedBuffer]
+ def getBlockData(blockId: String): ManagedBuffer
--- End diff --
Not sure how I feel about this taking a blockId as a string, especially if
it's implemented by the BlockManager itself. What's the reasoning behind not
taking a BlockId? Just too many users of the API that only have a String?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
