Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/2432#discussion_r18313615
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/DAGSchedulerSource.scala ---
@@ -22,10 +22,10 @@ import com.codahale.metrics.{Gauge,MetricRegistry}
import org.apache.spark.SparkContext
import org.apache.spark.metrics.source.Source
-private[spark] class DAGSchedulerSource(val dagScheduler: DAGScheduler,
sc: SparkContext)
+private[spark] class DAGSchedulerSource(val dagScheduler: DAGScheduler)
extends Source {
override val metricRegistry = new MetricRegistry()
- override val sourceName = "%s.DAGScheduler".format(sc.appName)
+ override val sourceName = "DAGScheduler"
--- End diff --
After this patch, I don't think that this `sourceName` is the full name of
the source. If you look at Spark's MetricsSystem.registerSource() method, it
takes the source name and prepends a bunch of app-specific information,
including the appId, appName, executorId, etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
