Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2432#discussion_r18313900
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1278,8 +1298,8 @@ class SparkContext(config: SparkConf) extends Logging
{
private def postApplicationStart() {
// Note: this code assumes that the task scheduler has been
initialized and has contacted
// the cluster manager to get an application ID (in case the cluster
manager provides one).
- listenerBus.post(SparkListenerApplicationStart(appName,
taskScheduler.applicationId(),
- startTime, sparkUser))
+ listenerBus.post(SparkListenerApplicationStart(appName,
+ Some(taskScheduler.applicationId().toString), startTime, sparkUser))
--- End diff --
I was actually proposing that we change it even in the
`SparkListenerApplicationStart`. I am aware that it's a public API, but at the
same time we haven't had any releases with #1218 yet so it won't break backward
compatibility. Now is the best time to change it; otherwise we'll be stuck with
having an option that will never be `None` forever.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
