Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131535507
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala ---
@@ -248,16 +248,16 @@ class DataFrameNaFunctionsSuite extends QueryTest
with SharedSQLContext {
assert(out(4) === Row("Amy", null, null))
assert(out(5) === Row(null, null, null))
- // Replace only the age column
- val out1 = input.na.replace("age", Map(
+ // Replace only the age column and with null
+ val out1 = input.na.replace("age", Map[Any, Any](
--- End diff --
How about rather adding a separate test and leaving the existing test as is?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
