Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/18820#discussion_r131559076
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1446,7 +1457,7 @@ def all_of_(xs):
if isinstance(to_replace, (float, int, long, basestring)):
to_replace = [to_replace]
- if isinstance(value, (float, int, long, basestring)):
+ if isinstance(value, (float, int, long, basestring)) or value is
None:
--- End diff --
This looks causing the warning always:
```python
>>> df = sc.parallelize([("Alice", 1, 3.0)]).toDF()
>>> df.replace({"Alice": "Bob"}).show()
```
```
.../spark/python/pyspark/sql/dataframe.py:1466: UserWarning: to_replace is
a dict and value is not None. value will be ignored.
warnings.warn("to_replace is a dict and value is not None. value will be
ignored.")
...
```
Could we put this line into 1468L (under `else`)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
