Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18820#discussion_r131535416
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -1428,9 +1438,9 @@ def all_of_(xs):
                     "to_replace should be a float, int, long, string, list, 
tuple, or dict. "
                     "Got {0}".format(type(to_replace)))
     
    -        if not isinstance(value, valid_types) and not 
isinstance(to_replace, dict):
    +        if not isinstance(value, valid_types + (type(None), )) and not 
isinstance(to_replace, dict):
    --- End diff --
    
    I would check `None` by `value is None`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to